Bluetooth: btusb: off by one in rtl8723b_parse_firmware()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 20 Apr 2015 15:51:35 +0000 (18:51 +0300)
committerMarcel Holtmann <marcel@holtmann.org>
Wed, 29 Apr 2015 23:05:30 +0000 (01:05 +0200)
The ">" should be ">=" so that we don't read past the end of the array.

Fixes: 9d9a113e3695 ('Bluetooth: btusb: Add Realtek 8723A/8723B/8761A/8821A support')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Daniel Drake <drake@endlessm.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
drivers/bluetooth/btusb.c

index 920f6fbd28ac8928e27033d593f1d2e017cc7813..d21f3b4176d3165f9541275964278db16dd24374 100644 (file)
@@ -1502,7 +1502,7 @@ static int rtl8723b_parse_firmware(struct hci_dev *hdev, u16 lmp_subver,
                return -EINVAL;
        }
 
-       if (project_id > ARRAY_SIZE(project_id_to_lmp_subver)) {
+       if (project_id >= ARRAY_SIZE(project_id_to_lmp_subver)) {
                BT_ERR("%s: unknown project id %d", hdev->name, project_id);
                return -EINVAL;
        }