qlcnic: Initialize mailbox cmd structure to zero
authorRajesh Borundia <rajesh.borundia@qlogic.com>
Wed, 4 Jun 2014 07:40:54 +0000 (03:40 -0400)
committerDavid S. Miller <davem@davemloft.net>
Thu, 5 Jun 2014 22:06:09 +0000 (15:06 -0700)
o Uninitialzed fields in mailbox command structure
  caused commands to time out randomly due to garbage
  values so initialize it to zero.

Signed-off-by: Rajesh Borundia <rajesh.borundia@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c

index 6afe9c1f5ab9337a3fa7c64e7863664af3db99b7..d9216afa93c19d16d865f0d2b69dac8b0e33654b 100644 (file)
@@ -454,6 +454,7 @@ static int qlcnic_sriov_get_vf_acl(struct qlcnic_adapter *adapter)
        struct qlcnic_cmd_args cmd;
        int ret = 0;
 
+       memset(&cmd, 0, sizeof(cmd));
        ret = qlcnic_sriov_alloc_bc_mbx_args(&cmd, QLCNIC_BC_CMD_GET_ACL);
        if (ret)
                return ret;
@@ -1441,6 +1442,7 @@ static int qlcnic_sriov_channel_cfg_cmd(struct qlcnic_adapter *adapter, u8 cmd_o
        struct qlcnic_vf_info *vf = &adapter->ahw->sriov->vf_info[0];
        int ret;
 
+       memset(&cmd, 0, sizeof(cmd));
        if (qlcnic_sriov_alloc_bc_mbx_args(&cmd, cmd_op))
                return -ENOMEM;
 
@@ -1998,6 +2000,7 @@ int qlcnic_sriov_cfg_vf_guest_vlan(struct qlcnic_adapter *adapter,
        struct qlcnic_cmd_args cmd;
        int ret;
 
+       memset(&cmd, 0, sizeof(cmd));
        if (vid == 0)
                return 0;