ACPI / sleep: Drain outstanding events after disabling multiple GPEs
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 1 Dec 2014 22:51:13 +0000 (23:51 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 1 Dec 2014 22:51:13 +0000 (23:51 +0100)
After multiple GPEs have been disabled at the low level in one go,
like when acpi_disable_all_gpes() is called, we should always drain
all of the outstanding events from them, or interesting races become
possible.

For this reason, call acpi_os_wait_events_complete() after
acpi_enable_all_wakeup_gpes() and acpi_disable_all_gpes() in
acpi_freeze_prepare() and acpi_power_off_prepare(), respectively.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/sleep.c

index 05a31b573fc327b2a843c314294eff18d6b288ba..8aa9254a387fb1c70e90857f70412aa44bceaa6b 100644 (file)
@@ -630,6 +630,7 @@ static int acpi_freeze_begin(void)
 static int acpi_freeze_prepare(void)
 {
        acpi_enable_all_wakeup_gpes();
+       acpi_os_wait_events_complete();
        enable_irq_wake(acpi_gbl_FADT.sci_interrupt);
        return 0;
 }
@@ -825,6 +826,7 @@ static void acpi_power_off_prepare(void)
        /* Prepare to power off the system */
        acpi_sleep_prepare(ACPI_STATE_S5);
        acpi_disable_all_gpes();
+       acpi_os_wait_events_complete();
 }
 
 static void acpi_power_off(void)