amd-xgbe: VLAN Rx tag stripping fix
authorLendacky, Thomas <Thomas.Lendacky@amd.com>
Tue, 24 Jun 2014 21:19:18 +0000 (16:19 -0500)
committerDavid S. Miller <davem@davemloft.net>
Fri, 27 Jun 2014 00:14:04 +0000 (17:14 -0700)
When receiving a VLAN packet check to be sure that VLAN
RX CTAG stripping is enabled before indicating that the
tag has been stripped in the packet information data
structure.

Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/amd/xgbe/xgbe-dev.c

index b239b216e191cccc5228fda0e924525c45c85a3e..d0f437945dd4aad0fe0e258825a255cb41ea0912 100644 (file)
@@ -1113,6 +1113,7 @@ static int xgbe_dev_read(struct xgbe_channel *channel)
        struct xgbe_ring_data *rdata;
        struct xgbe_ring_desc *rdesc;
        struct xgbe_packet_data *packet = &ring->packet_data;
+       struct net_device *netdev = channel->pdata->netdev;
        unsigned int err, etlt;
 
        DBGPR("-->xgbe_dev_read: cur = %d\n", ring->cur);
@@ -1153,7 +1154,8 @@ static int xgbe_dev_read(struct xgbe_channel *channel)
        DBGPR("  err=%u, etlt=%#x\n", err, etlt);
 
        if (!err || (err && !etlt)) {
-               if (etlt == 0x09) {
+               if ((etlt == 0x09) &&
+                   (netdev->features & NETIF_F_HW_VLAN_CTAG_RX)) {
                        XGMAC_SET_BITS(packet->attributes, RX_PACKET_ATTRIBUTES,
                                       VLAN_CTAG, 1);
                        packet->vlan_ctag = XGMAC_GET_BITS_LE(rdesc->desc0,