Missing pieces from cronjob commit
authorMatthias Schmidt <gravatronics@live.com>
Fri, 12 Aug 2011 20:24:33 +0000 (22:24 +0200)
committerMatthias Schmidt <gravatronics@live.com>
Fri, 12 Aug 2011 20:24:33 +0000 (22:24 +0200)
I have no idea what went wrong with that specific commit, but here are
again missing pieces of my cronjob commit. This time I replaced the
classPath property of a cronjob with className in cronjob log lists.

wcfsetup/install/files/acp/templates/cronjobLogList.tpl
wcfsetup/install/files/lib/acp/page/CronjobLogListPage.class.php

index 665b7ff502e15c3b9862fbfa2330c398b77c9305..3c21b6a6a87c1679467951811498cfb96981b84e 100644 (file)
@@ -25,7 +25,7 @@
                                <thead>
                                        <tr>
                                                <th class="columnCronjobID{if $sortField == 'cronjobID'} active{/if}"><p><a href="index.php?page=CronjobLogList&amp;pageNo={@$pageNo}&amp;sortField=cronjobID&amp;sortOrder={if $sortField == 'cronjobID' && $sortOrder == 'ASC'}DESC{else}ASC{/if}{@SID_ARG_2ND}">{lang}wcf.acp.cronjob.cronjobID{/lang}{if $sortField == 'cronjobID'} <img src="{@RELATIVE_WCF_DIR}icon/sort{@$sortOrder}S.png" alt="" />{/if}</a></p></th>
-                                               <th class="columnClassPath{if $sortField == 'classPath'} active{/if}"><p><a href="index.php?page=CronjobLogList&amp;pageNo={@$pageNo}&amp;sortField=classPath&amp;sortOrder={if $sortField == 'classPath' && $sortOrder == 'ASC'}DESC{else}ASC{/if}{@SID_ARG_2ND}">{lang}wcf.acp.cronjob.classPath{/lang}{if $sortField == 'classPath'} <img src="{@RELATIVE_WCF_DIR}icon/sort{@$sortOrder}S.png" alt="" />{/if}</a></p></th>
+                                               <th class="columnClassName{if $sortField == 'className'} active{/if}"><p><a href="index.php?page=CronjobLogList&amp;pageNo={@$pageNo}&amp;sortField=className&amp;sortOrder={if $sortField == 'className' && $sortOrder == 'ASC'}DESC{else}ASC{/if}{@SID_ARG_2ND}">{lang}wcf.acp.cronjob.className{/lang}{if $sortField == 'className'} <img src="{@RELATIVE_WCF_DIR}icon/sort{@$sortOrder}S.png" alt="" />{/if}</a></p></th>
                                                <th class="columnDescription{if $sortField == 'description'} active{/if}"><p><a href="index.php?page=CronjobLogList&amp;pageNo={@$pageNo}&amp;sortField=description&amp;sortOrder={if $sortField == 'description' && $sortOrder == 'ASC'}DESC{else}ASC{/if}{@SID_ARG_2ND}">{lang}wcf.acp.cronjob.description{/lang}{if $sortField == 'description'} <img src="{@RELATIVE_WCF_DIR}icon/sort{@$sortOrder}S.png" alt="" />{/if}</a></p></th>
                                                <th class="columnExecTime{if $sortField == 'execTime'} active{/if}"><p><a href="index.php?page=CronjobLogList&amp;pageNo={@$pageNo}&amp;sortField=execTime&amp;sortOrder={if $sortField == 'execTime' && $sortOrder == 'ASC'}DESC{else}ASC{/if}{@SID_ARG_2ND}">{lang}wcf.acp.cronjob.log.execTime{/lang}{if $sortField == 'execTime'} <img src="{@RELATIVE_WCF_DIR}icon/sort{@$sortOrder}S.png" alt="" />{/if}</a></p></th>
                                                
@@ -38,7 +38,7 @@
                                        {foreach from=$cronjobLogs item=cronjobLog}
                                                <tr>
                                                        <td class="columnCronjobID columnID"><p>{@$cronjobLog->cronjobID}</p></td>
-                                                       <td class="columnClassPath columnText"><p>{$cronjobLog->classPath}</p></td>
+                                                       <td class="columnClassName columnText"><p>{$cronjobLog->className}</p></td>
                                                        <td class="columnDescription columnText"><p>{$cronjobLog->description}</p></td>
                                                        {if $cronjobLog->success}
                                                                <td class="columnExecTime columnDate"><p>{@$cronjobLog->execTime|time} {lang}wcf.acp.cronjob.log.success{/lang}</p></td>
index 47edfcadcf511fa15f5b30070558ad16cbc9de8c..b42aa0d95b66ef9dda60851baec3ded10ec53f1f 100755 (executable)
@@ -44,7 +44,7 @@ class CronjobLogListPage extends SortablePage {
        /**
         * @see wcf\page\SortablePage::$validSortFields
         */
-       public $validSortFields = array('cronjobID', 'classPath', 'description', 'execTime', 'success');
+       public $validSortFields = array('cronjobID', 'className', 'description', 'execTime', 'success');
        
        /**
         * @see wcf\page\MultipleLinkPage::$objectListClassName
@@ -66,7 +66,7 @@ class CronjobLogListPage extends SortablePage {
         * @see wcf\page\MultipleLinkPage::readObjects()
         */
        protected function readObjects() {
-               $this->sqlOrderBy = (($this->sortField == 'classPath' || $this->sortField == 'description') ? 'cronjob.' : 'cronjob_log.').$this->sortField." ".$this->sortOrder;
+               $this->sqlOrderBy = (($this->sortField == 'className' || $this->sortField == 'description') ? 'cronjob.' : 'cronjob_log.').$this->sortField." ".$this->sortOrder;
                
                parent::readObjects();
        }