of: Delete unnecessary check before calling "of_node_put()"
authorMarkus Elfring <elfring@users.sourceforge.net>
Tue, 2 Dec 2014 12:54:00 +0000 (13:54 +0100)
committerGrant Likely <grant.likely@linaro.org>
Wed, 3 Dec 2014 23:12:41 +0000 (23:12 +0000)
The of_node_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Grant Likely <grant.likely@linaro.org>
drivers/of/unittest.c

index 1807a045864878eb372db38357bf2de761ab13ad..844838e11ef1a1f8f4d6ac9b52721a1b668dc6aa 100644 (file)
@@ -516,8 +516,7 @@ static void __init of_selftest_changeset(void)
        /* Make sure node names are constructed correctly */
        selftest((np = of_find_node_by_path("/testcase-data/changeset/n2/n21")),
                 "'%s' not added\n", n21->full_name);
-       if (np)
-               of_node_put(np);
+       of_node_put(np);
 
        mutex_lock(&of_mutex);
        selftest(!of_changeset_revert(&chgset), "revert failed\n");