clk: replace pr_warn() with pr_err() for fatal cases
authorMasahiro Yamada <yamada.masahiro@socionext.com>
Mon, 28 Dec 2015 10:23:03 +0000 (19:23 +0900)
committerStephen Boyd <sboyd@codeaurora.org>
Tue, 2 Feb 2016 01:01:59 +0000 (17:01 -0800)
These three cases let clk_register() fail.  They should be considered
as error messages.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
drivers/clk/clk.c

index 98c68e99d5f654ba41a7e648cd4be72debfc2fb3..09d84453ea3a048c69168cf025c4c013769dd2e1 100644 (file)
@@ -2320,22 +2320,22 @@ static int __clk_core_init(struct clk_core *core)
        if (core->ops->set_rate &&
            !((core->ops->round_rate || core->ops->determine_rate) &&
              core->ops->recalc_rate)) {
-               pr_warning("%s: %s must implement .round_rate or .determine_rate in addition to .recalc_rate\n",
-                               __func__, core->name);
+               pr_err("%s: %s must implement .round_rate or .determine_rate in addition to .recalc_rate\n",
+                      __func__, core->name);
                ret = -EINVAL;
                goto out;
        }
 
        if (core->ops->set_parent && !core->ops->get_parent) {
-               pr_warning("%s: %s must implement .get_parent & .set_parent\n",
-                               __func__, core->name);
+               pr_err("%s: %s must implement .get_parent & .set_parent\n",
+                      __func__, core->name);
                ret = -EINVAL;
                goto out;
        }
 
        if (core->ops->set_rate_and_parent &&
                        !(core->ops->set_parent && core->ops->set_rate)) {
-               pr_warn("%s: %s must implement .set_parent & .set_rate\n",
+               pr_err("%s: %s must implement .set_parent & .set_rate\n",
                                __func__, core->name);
                ret = -EINVAL;
                goto out;