staging: wilc1000: change handle_set_channel's return type to void
authorChaehyun Lim <chaehyun.lim@gmail.com>
Fri, 12 Feb 2016 14:04:44 +0000 (23:04 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 15 Feb 2016 00:25:38 +0000 (16:25 -0800)
When handle_set_channel is called in hostIFthread that is a kernel
thread, it is not checked return type of this function. This patch
changes return type to void and removes braces if statement due
to have a single statement.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wilc1000/host_interface.c

index e9a6aa7f4afbe2037517fb392d4b4416d6e63562..eecd697c3f0274761f34741ea7a988eb71bae57b 100644 (file)
@@ -299,8 +299,8 @@ static struct wilc_vif *wilc_get_vif_from_idx(struct wilc *wilc, int idx)
        return wilc->vif[index];
 }
 
-static s32 handle_set_channel(struct wilc_vif *vif,
-                             struct channel_attr *hif_set_ch)
+static void handle_set_channel(struct wilc_vif *vif,
+                              struct channel_attr *hif_set_ch)
 {
        s32 result = 0;
        struct wid wid;
@@ -313,12 +313,8 @@ static s32 handle_set_channel(struct wilc_vif *vif,
        result = wilc_send_config_pkt(vif, SET_CFG, &wid, 1,
                                      wilc_get_vif_idx(vif));
 
-       if (result) {
+       if (result)
                PRINT_ER("Failed to set channel\n");
-               return -EINVAL;
-       }
-
-       return result;
 }
 
 static s32 handle_set_wfi_drv_handler(struct wilc_vif *vif,