net/mlx4_en: Use generic etherdevice.h functions.
authorYan Burman <yanb@mellanox.com>
Wed, 12 Dec 2012 02:13:18 +0000 (02:13 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 12 Dec 2012 18:02:30 +0000 (13:02 -0500)
Get rid of full_mac, zero_mac in favour of
is_zero_ether_addr and is_broadcast_ether_addr.

Signed-off-by: Yan Burman <yanb@mellanox.com>
Signed-off-by: Amir Vadai <amirv@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx4/en_ethtool.c

index 4aaa7c3ad22f50b3bc94444ebd00003f69bdec25..cc7bb25c7e40d79d3069a074a9cc4d3954c7702c 100644 (file)
@@ -613,8 +613,6 @@ static int mlx4_en_validate_flow(struct net_device *dev,
        struct ethtool_usrip4_spec *l3_mask;
        struct ethtool_tcpip4_spec *l4_mask;
        struct ethhdr *eth_mask;
-       u64 full_mac = ~0ull;
-       u64 zero_mac = 0;
 
        if (cmd->fs.location >= MAX_NUM_OF_FS_RULES)
                return -EINVAL;
@@ -644,11 +642,11 @@ static int mlx4_en_validate_flow(struct net_device *dev,
        case ETHER_FLOW:
                eth_mask = &cmd->fs.m_u.ether_spec;
                /* source mac mask must not be set */
-               if (memcmp(eth_mask->h_source, &zero_mac, ETH_ALEN))
+               if (!is_zero_ether_addr(eth_mask->h_source))
                        return -EINVAL;
 
                /* dest mac mask must be ff:ff:ff:ff:ff:ff */
-               if (memcmp(eth_mask->h_dest, &full_mac, ETH_ALEN))
+               if (!is_broadcast_ether_addr(eth_mask->h_dest))
                        return -EINVAL;
 
                if (!all_zeros_or_all_ones(eth_mask->h_proto))