Btrfs: use kmem_cache_free when freeing entry in inode cache
authorFilipe Manana <fdmanana@suse.com>
Sat, 13 Jun 2015 05:52:56 +0000 (06:52 +0100)
committerChris Mason <clm@fb.com>
Tue, 30 Jun 2015 21:36:46 +0000 (14:36 -0700)
The free space entries are allocated using kmem_cache_zalloc(),
through __btrfs_add_free_space(), therefore we should use
kmem_cache_free() and not kfree() to avoid any confusion and
any potential problem. Looking at the kfree() definition at
mm/slab.c it has the following comment:

  /*
   * (...)
   *
   * Don't free memory not originally allocated by kmalloc()
   * or you will run into trouble.
   */

So better be safe and use kmem_cache_free().

Cc: stable@vger.kernel.org
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Chris Mason <clm@fb.com>
fs/btrfs/inode-map.c

index f6a596d5a6374f1dbf66279e24ef17aed9ff399d..218df701e6071c83807b89979517f035d6e2a155 100644 (file)
@@ -271,7 +271,7 @@ void btrfs_unpin_free_ino(struct btrfs_root *root)
                __btrfs_add_free_space(ctl, info->offset, count);
 free:
                rb_erase(&info->offset_index, rbroot);
-               kfree(info);
+               kmem_cache_free(btrfs_free_space_cachep, info);
        }
 }