projects
/
GitHub
/
exynos8895
/
android_kernel_samsung_universal8895.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
5a19b17
)
ALSA: mips/ad1843: Use WARN_ON() instead of BUG_ON()
author
Takashi Iwai
<tiwai@suse.de>
Tue, 5 Nov 2013 14:03:05 +0000
(15:03 +0100)
committer
Takashi Iwai
<tiwai@suse.de>
Wed, 6 Nov 2013 07:35:16 +0000
(08:35 +0100)
BUG_ON() is rather useless for debugging as it leads to panic().
Use WARN_ON() and handle the error cases accordingly.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/mips/ad1843.c
patch
|
blob
|
blame
|
history
diff --git
a/sound/mips/ad1843.c
b/sound/mips/ad1843.c
index c624510ec37476eccfec30d0e5c48ac2ec9647be..586907500ca534eb6ebea572795dc7725d8dade0 100644
(file)
--- a/
sound/mips/ad1843.c
+++ b/
sound/mips/ad1843.c
@@
-276,7
+276,7
@@
static void ad1843_write_multi(struct snd_ad1843 *ad1843, int argcount, ...)
if (reg == -1)
reg = fp->reg;
else
-
BUG
_ON(reg != fp->reg);
+
WARN
_ON(reg != fp->reg);
m = ((1 << fp->nbits) - 1) << fp->lo_bit;
mask |= m;
bits |= (value << fp->lo_bit) & m;