do_dentry_open(): close the race with mark_files_ro() in failure exit

we want to take it out of mark_files_ro() reach *before* we start
checking if we ought to drop write access.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

diff --git a/fs/open.c b/fs/open.c
index 124ccb1d38a032b66f312d3e0ffdbb336c7db16f..764cc9c201a58f8fd75d1f90d98269c368b1d475 100644 (file)
--- a/fs/open.c
+++ b/fs/open.c
@@ -727,6 +727,7 @@ static int do_dentry_open(struct file *f,
 
 cleanup_all:
        fops_put(f->f_op);
+       file_sb_list_del(f);
        if (f->f_mode & FMODE_WRITE) {
                put_write_access(inode);
                if (!special_file(inode->i_mode)) {
@@ -740,7 +741,6 @@ cleanup_all:
                        mnt_drop_write(f->f_path.mnt);
                }
        }
-       file_sb_list_del(f);
 cleanup_file:
        path_put(&f->f_path);
        f->f_path.mnt = NULL;