ALSA: hda - Use acpi_dev_present()
authorLukas Wunner <lukas@wunner.de>
Thu, 14 Jan 2016 21:05:03 +0000 (22:05 +0100)
committerTakashi Iwai <tiwai@suse.de>
Sun, 21 Feb 2016 08:16:00 +0000 (09:16 +0100)
Use shiny new acpi_dev_present() and remove all the boilerplate
to search for a particular ACPI device. No functional change.
Cf. 2d12b6b381ba ("ACPI / utils: Add acpi_dev_present()").

Signed-off-by: Lukas Wunner <lukas@wunner.de>
Acked-by: Hui Wang <hui.wang@canonical.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/thinkpad_helper.c

index 0a4ad5feb82e7817f7036f86c973d02b1dfecb9b..59ab6cee1ad8244a320940a45f09109d0423a207 100644 (file)
 static int (*led_set_func)(int, bool);
 static void (*old_vmaster_hook)(void *, int);
 
-static acpi_status acpi_check_cb(acpi_handle handle, u32 lvl, void *context,
-                                void **rv)
-{
-       bool *found = context;
-       *found = true;
-       return AE_OK;
-}
-
 static bool is_thinkpad(struct hda_codec *codec)
 {
-       bool found = false;
-       if (codec->core.subsystem_id >> 16 != 0x17aa)
-               return false;
-       if (ACPI_SUCCESS(acpi_get_devices("LEN0068", acpi_check_cb, &found, NULL)) && found)
-               return true;
-       found = false;
-       return ACPI_SUCCESS(acpi_get_devices("IBM0068", acpi_check_cb, &found, NULL)) && found;
+       return (codec->core.subsystem_id >> 16 == 0x17aa) &&
+              (acpi_dev_present("LEN0068") || acpi_dev_present("IBM0068"));
 }
 
 static void update_tpacpi_mute_led(void *private_data, int enabled)