scsi: sd: change manage_start_stop to bool in sysfs interface

[ Upstream commit 623401ee33e42cee64d333877892be8db02951eb ]

/sys/class/scsi_disk/0:2:0:0/manage_start_stop can be changed to 0
unexpectly by writing an invalid string.

Signed-off-by: weiping zhang <zhangweiping@didichuxing.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 7e1681cf287c1e226e770035505a4b0b02958f79..19bfa7646c2b83f2f0c5d2354794f4edc3652c17 100644 (file)
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -233,11 +233,15 @@ manage_start_stop_store(struct device *dev, struct device_attribute *attr,
 {
        struct scsi_disk *sdkp = to_scsi_disk(dev);
        struct scsi_device *sdp = sdkp->device;
+       bool v;
 
        if (!capable(CAP_SYS_ADMIN))
                return -EACCES;
 
-       sdp->manage_start_stop = simple_strtoul(buf, NULL, 10);
+       if (kstrtobool(buf, &v))
+               return -EINVAL;
+
+       sdp->manage_start_stop = v;
 
        return count;
 }