netfilter: nft_compat: use _safe version of list_for_each

We need to use the _safe version of list_for_each_entry() here otherwise
we have a use after free bug.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

diff --git a/net/netfilter/nft_compat.c b/net/netfilter/nft_compat.c
index 4811f762e0600f78c44a5928690aaba762adae1e..a82667c64729a3964e8fbd44f0ddd69d1cefa5c3 100644 (file)
--- a/net/netfilter/nft_compat.c
+++ b/net/netfilter/nft_compat.c
@@ -634,9 +634,9 @@ nft_match_select_ops(const struct nft_ctx *ctx,
 
 static void nft_match_release(void)
 {
-       struct nft_xt *nft_match;
+       struct nft_xt *nft_match, *tmp;
 
-       list_for_each_entry(nft_match, &nft_match_list, head)
+       list_for_each_entry_safe(nft_match, tmp, &nft_match_list, head)
                kfree(nft_match);
 }
 
@@ -705,9 +705,9 @@ nft_target_select_ops(const struct nft_ctx *ctx,
 
 static void nft_target_release(void)
 {
-       struct nft_xt *nft_target;
+       struct nft_xt *nft_target, *tmp;
 
-       list_for_each_entry(nft_target, &nft_target_list, head)
+       list_for_each_entry_safe(nft_target, tmp, &nft_target_list, head)
                kfree(nft_target);
 }