sh: Fix lockdep debugging oops on SH-3/4.
authorPaul Mundt <lethal@linux-sh.org>
Wed, 1 Aug 2007 07:17:07 +0000 (16:17 +0900)
committerPaul Mundt <lethal@linux-sh.org>
Wed, 1 Aug 2007 07:17:07 +0000 (16:17 +0900)
In the SH-3/4 TLB access violation path we were enabling IRQs before
the call in to trace_hardirqs_on(), which ended up triggering:

        if (DEBUG_LOCKS_WARN_ON(!irqs_disabled()))
                return;

in kernel/lockdep.c:2031. Fix this up by removing the early re-enable,
we were already re-enabling IRQs post-trace_hardirqs_on() already, so
the semantics are now as was initially intended.

Signed-off-by: Paul Mundt <lethal@linux-sh.org>
arch/sh/kernel/cpu/sh3/entry.S

index d8e122971c3e2caaa78028513b8f3a61d78de425..0d12a124055ca7d4a31ffaee1e955dc654cb7bc4 100644 (file)
@@ -149,8 +149,7 @@ call_dpf:
         lds    r10, pr
        rts
         nop
-0:     sti
-       mov.l   3f, r0
+0:     mov.l   3f, r0
        mov     r9, r6
        mov     r8, r5
        jmp     @r0