MSI: Simplify BUG() handling in msi_remove_pci_irq_vectors() part 1
authorMichael Ellerman <michael@ellerman.id.au>
Thu, 22 Mar 2007 10:51:31 +0000 (21:51 +1100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 3 May 2007 02:02:36 +0000 (19:02 -0700)
Although it might be nice to do a printk before BUG'ing, it's really not
necessary, and it complicates the code.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Acked-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/pci/msi.c

index db452319be90b968cd67625bcea753a38f566e94..2a119f8d0dc69bba2fe762f1a8216067ad3361c1 100644 (file)
@@ -719,13 +719,8 @@ void msi_remove_pci_irq_vectors(struct pci_dev* dev)
                return;
 
        if (dev->msi_enabled) {
-               if (irq_has_action(dev->first_msi_irq)) {
-                       printk(KERN_WARNING "PCI: %s: msi_remove_pci_irq_vectors() "
-                              "called without free_irq() on MSI irq %d\n",
-                              pci_name(dev), dev->first_msi_irq);
-                       BUG_ON(irq_has_action(dev->first_msi_irq));
-               } else /* Release MSI irq assigned to this device */
-                       msi_free_irq(dev, dev->first_msi_irq);
+               BUG_ON(irq_has_action(dev->first_msi_irq));
+               msi_free_irq(dev, dev->first_msi_irq);
        }
        if (dev->msix_enabled) {
                int irq, head, tail = 0, warning = 0;