hwmon: (twl4030-madc-hwmon) Return proper error if hwmon_device_register fails
authorAxel Lin <axel.lin@gmail.com>
Sun, 1 May 2011 15:34:55 +0000 (11:34 -0400)
committerGuenter Roeck <guenter.roeck@ericsson.com>
Sun, 1 May 2011 16:06:35 +0000 (09:06 -0700)
The driver did not return an error if the call to hwmon_device_register failed.
Fix by returning the error reported from hwmon_device_register.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
drivers/hwmon/twl4030-madc-hwmon.c

index de5819199e2e35cd65d8b2816431328a3ddd58cf..57240740b161d190329b5ca3b7dfaf0d049ef02e 100644 (file)
@@ -98,7 +98,6 @@ static const struct attribute_group twl4030_madc_group = {
 static int __devinit twl4030_madc_hwmon_probe(struct platform_device *pdev)
 {
        int ret;
-       int status;
        struct device *hwmon;
 
        ret = sysfs_create_group(&pdev->dev.kobj, &twl4030_madc_group);
@@ -107,7 +106,7 @@ static int __devinit twl4030_madc_hwmon_probe(struct platform_device *pdev)
        hwmon = hwmon_device_register(&pdev->dev);
        if (IS_ERR(hwmon)) {
                dev_err(&pdev->dev, "hwmon_device_register failed.\n");
-               status = PTR_ERR(hwmon);
+               ret = PTR_ERR(hwmon);
                goto err_reg;
        }