drm/exynos: remove extra call to hdmi_commit()
authorGustavo Padovan <gustavo.padovan@collabora.co.uk>
Wed, 5 Aug 2015 23:24:17 +0000 (20:24 -0300)
committerInki Dae <inki.dae@samsung.com>
Sun, 16 Aug 2015 01:23:37 +0000 (10:23 +0900)
hdmi_commit() was getting called twice by exynos encoder core, once inside
the .enable() call and another time by .commit() itself.

Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
drivers/gpu/drm/exynos/exynos_hdmi.c

index 1aed7eadcd79ec3e55dd1c0b1fe76c7bd4fa1a60..11bac50f3a8e049a5384ac9b06eb48c49918288b 100644 (file)
@@ -1711,16 +1711,6 @@ static void hdmi_mode_set(struct exynos_drm_encoder *encoder,
        hdata->cea_video_id = drm_match_cea_mode(mode);
 }
 
-static void hdmi_commit(struct exynos_drm_encoder *encoder)
-{
-       struct hdmi_context *hdata = encoder_to_hdmi(encoder);
-
-       if (!hdata->powered)
-               return;
-
-       hdmi_conf_apply(hdata);
-}
-
 static void hdmi_enable(struct exynos_drm_encoder *encoder)
 {
        struct hdmi_context *hdata = encoder_to_hdmi(encoder);
@@ -1744,7 +1734,7 @@ static void hdmi_enable(struct exynos_drm_encoder *encoder)
        clk_prepare_enable(res->sclk_hdmi);
 
        hdmiphy_poweron(hdata);
-       hdmi_commit(encoder);
+       hdmi_conf_apply(hdata);
 }
 
 static void hdmi_disable(struct exynos_drm_encoder *encoder)
@@ -1798,7 +1788,6 @@ static struct exynos_drm_encoder_ops hdmi_encoder_ops = {
        .mode_set       = hdmi_mode_set,
        .enable         = hdmi_enable,
        .disable        = hdmi_disable,
-       .commit         = hdmi_commit,
 };
 
 static void hdmi_hotplug_work_func(struct work_struct *work)