drm/i915/skl: remove redundant DDI/IRQ reinitialization during PW1 enabling
authorImre Deak <imre.deak@intel.com>
Wed, 4 Nov 2015 17:24:19 +0000 (19:24 +0200)
committerImre Deak <imre.deak@intel.com>
Tue, 17 Nov 2015 18:55:16 +0000 (20:55 +0200)
We don't need to reinit DDI and IRQs during PW1 enabling any more, since
we don't toggle PW1 on-demand any more. We enable PW1 only as part of
the display core init sequence and after this we initialize both DDI and
IRQs later in the init sequence. So remove these init steps from the
power well code.

Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Patrik Jakobsson <patrik.jakobsson@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1446657859-9598-11-git-send-email-imre.deak@intel.com
drivers/gpu/drm/i915/intel_runtime_pm.c

index 4b3ae49754ccec7b63649265f191f37b88f69fc2..238ba742be601a2489e92c820cb0b53d17672430 100644 (file)
@@ -244,11 +244,6 @@ static void skl_power_well_post_enable(struct drm_i915_private *dev_priv,
                gen8_irq_power_well_post_enable(dev_priv,
                                                1 << PIPE_C | 1 << PIPE_B);
        }
-
-       if (power_well->data == SKL_DISP_PW_1) {
-               intel_prepare_ddi(dev);
-               gen8_irq_power_well_post_enable(dev_priv, 1 << PIPE_A);
-       }
 }
 
 static void hsw_set_power_well(struct drm_i915_private *dev_priv,