projects / GitHub / LineageOS / G12 / android_kernel_amlogic_linux-4.9.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 6da95e1)
ALSA: hdsp: Deletion of an unnecessary check before the function call "release_firmware"
authorMarkus Elfring <elfring@users.sourceforge.net>
Mon, 17 Nov 2014 12:04:14 +0000 (13:04 +0100)
committerTakashi Iwai <tiwai@suse.de>
Mon, 17 Nov 2014 12:46:46 +0000 (13:46 +0100)
The release_firmware() function tests whether its argument is NULL and then
return immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/rme9652/hdsp.c patch | blob | blame | history

diff --git a/sound/pci/rme9652/hdsp.c b/sound/pci/rme9652/hdsp.c
index 2eb8baf7b8283c2cf7e67bb2b85cb372ee8a772f..cf5a6c8b9a63a36aee58b438e58190be9f6231df 100644 (file)
--- a/sound/pci/rme9652/hdsp.c
+++ b/sound/pci/rme9652/hdsp.c
@@ -5307,8 +5307,7 @@ static int snd_hdsp_free(struct hdsp *hdsp)
 
        snd_hdsp_free_buffers(hdsp);
 
-       if (hdsp->firmware)
-               release_firmware(hdsp->firmware);
+       release_firmware(hdsp->firmware);
        vfree(hdsp->fw_uploaded);
 
        if (hdsp->iobase)