drm/radeon: remove radeon_bo_clear_va
authorChristian König <christian.koenig@amd.com>
Fri, 18 Jul 2014 07:24:54 +0000 (09:24 +0200)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 5 Aug 2014 12:53:50 +0000 (08:53 -0400)
Won't work anyway, instead WARN_ON if the VA list isn't
empty when we free the BO.

Signed-off-by: Christian König <christian.koenig@amd.com>
Tested-by: Michel Dänzer <michel.daenzer@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/radeon/radeon_object.c

index a00cf17a051044314fbeb175bd8c6a0f637950a2..78b74c88d1450ed9ef45a2a177a0ee6ffea893e0 100644 (file)
@@ -46,16 +46,6 @@ static void radeon_bo_clear_surface_reg(struct radeon_bo *bo);
  * function are calling it.
  */
 
-static void radeon_bo_clear_va(struct radeon_bo *bo)
-{
-       struct radeon_bo_va *bo_va, *tmp;
-
-       list_for_each_entry_safe(bo_va, tmp, &bo->va, bo_list) {
-               /* remove from all vm address space */
-               radeon_vm_bo_rmv(bo->rdev, bo_va);
-       }
-}
-
 static void radeon_update_memory_usage(struct radeon_bo *bo,
                                       unsigned mem_type, int sign)
 {
@@ -90,7 +80,7 @@ static void radeon_ttm_bo_destroy(struct ttm_buffer_object *tbo)
        list_del_init(&bo->list);
        mutex_unlock(&bo->rdev->gem.mutex);
        radeon_bo_clear_surface_reg(bo);
-       radeon_bo_clear_va(bo);
+       WARN_ON(!list_empty(&bo->va));
        drm_gem_object_release(&bo->gem_base);
        kfree(bo);
 }