Disable MCP limit exceeded messages from Intel IPS driver
authorAndi Kleen <ak@linux.intel.com>
Mon, 6 Feb 2012 16:17:12 +0000 (08:17 -0800)
committerLen Brown <len.brown@intel.com>
Fri, 30 Mar 2012 20:06:12 +0000 (16:06 -0400)
On a system on the thermal limit these are quite noisy and flood the logs.
Better would be a counter anyways. But given that we don't even have
anything for normal throttling this doesn't seem to be urgent either.

Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
drivers/platform/x86/intel_ips.c

index 88a98cff5a44a04e2d69771cc78ec7de3edbce82..f7ba316e0ed612f7adddafd75fe7f94b13d78656 100644 (file)
@@ -609,25 +609,16 @@ static bool mcp_exceeded(struct ips_driver *ips)
        bool ret = false;
        u32 temp_limit;
        u32 avg_power;
-       const char *msg = "MCP limit exceeded: ";
 
        spin_lock_irqsave(&ips->turbo_status_lock, flags);
 
        temp_limit = ips->mcp_temp_limit * 100;
-       if (ips->mcp_avg_temp > temp_limit) {
-               dev_info(&ips->dev->dev,
-                       "%sAvg temp %u, limit %u\n", msg, ips->mcp_avg_temp,
-                       temp_limit);
+       if (ips->mcp_avg_temp > temp_limit)
                ret = true;
-       }
 
        avg_power = ips->cpu_avg_power + ips->mch_avg_power;
-       if (avg_power > ips->mcp_power_limit) {
-               dev_info(&ips->dev->dev,
-                       "%sAvg power %u, limit %u\n", msg, avg_power,
-                       ips->mcp_power_limit);
+       if (avg_power > ips->mcp_power_limit)
                ret = true;
-       }
 
        spin_unlock_irqrestore(&ips->turbo_status_lock, flags);