iio: pressure: hid-sensor-press: Fix memory leak in probe()

'channels' is allocated via kmemdup and it is never freed in the
subsequent error paths.

Use 'indio_dev->channels' directly instead, so that we avoid such
memory leak problem.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>

diff --git a/drivers/iio/pressure/hid-sensor-press.c b/drivers/iio/pressure/hid-sensor-press.c
index f3305d80c0b803d420a847b865da1851b4bf45e6..c060bd847f540af5c9cc5e840dbcb7c94c0c598a 100644 (file)
--- a/drivers/iio/pressure/hid-sensor-press.c
+++ b/drivers/iio/pressure/hid-sensor-press.c
@@ -262,7 +262,6 @@ static int hid_press_probe(struct platform_device *pdev)
        struct iio_dev *indio_dev;
        struct press_state *press_state;
        struct hid_sensor_hub_device *hsdev = pdev->dev.platform_data;
-       struct iio_chan_spec *channels;
 
        indio_dev = devm_iio_device_alloc(&pdev->dev,
                                sizeof(struct press_state));
@@ -282,20 +281,21 @@ static int hid_press_probe(struct platform_device *pdev)
                return ret;
        }
 
-       channels = kmemdup(press_channels, sizeof(press_channels), GFP_KERNEL);
-       if (!channels) {
+       indio_dev->channels = kmemdup(press_channels, sizeof(press_channels),
+                                     GFP_KERNEL);
+       if (!indio_dev->channels) {
                dev_err(&pdev->dev, "failed to duplicate channels\n");
                return -ENOMEM;
        }
 
-       ret = press_parse_report(pdev, hsdev, channels,
-                               HID_USAGE_SENSOR_PRESSURE, press_state);
+       ret = press_parse_report(pdev, hsdev,
+                                (struct iio_chan_spec *)indio_dev->channels,
+                                HID_USAGE_SENSOR_PRESSURE, press_state);
        if (ret) {
                dev_err(&pdev->dev, "failed to setup attributes\n");
                goto error_free_dev_mem;
        }
 
-       indio_dev->channels = channels;
        indio_dev->num_channels =
                                ARRAY_SIZE(press_channels);
        indio_dev->dev.parent = &pdev->dev;