Make Tar::extractToString() much faster

We are building a full in memory string instead of streaming, so let
PHP perform the heavy lifting of building the string in C instead of
doing it manually in 512 Byte chunks.

diff --git a/wcfsetup/install/files/lib/system/io/Tar.class.php b/wcfsetup/install/files/lib/system/io/Tar.class.php
index 2c5f32144820086d5880f1f43083f2334d596581..05357e37401ea04f1cf4d8f7915969ae7ff364be 100644 (file)
--- a/wcfsetup/install/files/lib/system/io/Tar.class.php
+++ b/wcfsetup/install/files/lib/system/io/Tar.class.php
@@ -180,15 +180,7 @@ class Tar implements IArchive {
                $this->file->seek($header['offset']);
                
                // read data
-               $content = '';
-               $n = floor($header['size'] / 512);
-               for ($i = 0; $i < $n; $i++) {
-                       $content .= $this->file->read(512);
-               }
-               if (($header['size'] % 512) != 0) {
-                       $buffer = $this->file->read(512);
-                       $content .= substr($buffer, 0, $header['size'] % 512);
-               }
+               $content = $this->file->read($header['size']);
                
                return $content;
        }