spi: pxa2xx: Move chip select control bits into lpss_config structure

Some Intel LPSS SPI controllers, like the one in Braswell has these bits in
a different location so move these bits to be part of the LPSS
configuration.

Since not all LPSS SPI controllers support multiple native chip selects we
refactor selecting chip select to its own function and check
control->cs_sel_mask before switching to another chip select.

Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c
index 7d6d3b74d25b3972183008cf5f803180e0113e97..81d68e01046aee8e5c4046d96d00b38597d217bc 100644 (file)
--- a/drivers/spi/spi-pxa2xx.c
+++ b/drivers/spi/spi-pxa2xx.c
@@ -65,8 +65,6 @@ MODULE_ALIAS("platform:pxa2xx-spi");
 #define LPSS_GENERAL_REG_RXTO_HOLDOFF_DISABLE  BIT(24)
 #define LPSS_CS_CONTROL_SW_MODE                        BIT(0)
 #define LPSS_CS_CONTROL_CS_HIGH                        BIT(1)
-#define LPSS_CS_CONTROL_CS_SEL_SHIFT           8
-#define LPSS_CS_CONTROL_CS_SEL_MASK            (3 << LPSS_CS_CONTROL_CS_SEL_SHIFT)
 #define LPSS_CAPS_CS_EN_SHIFT                  9
 #define LPSS_CAPS_CS_EN_MASK                   (0xf << LPSS_CAPS_CS_EN_SHIFT)
 
@@ -82,6 +80,9 @@ struct lpss_config {
        u32 rx_threshold;
        u32 tx_threshold_lo;
        u32 tx_threshold_hi;
+       /* Chip select control */
+       unsigned cs_sel_shift;
+       unsigned cs_sel_mask;
 };
 
 /* Keep these sorted with enum pxa_ssp_type */
@@ -125,6 +126,8 @@ static const struct lpss_config lpss_platforms[] = {
                .rx_threshold = 1,
                .tx_threshold_lo = 16,
                .tx_threshold_hi = 48,
+               .cs_sel_shift = 8,
+               .cs_sel_mask = 3 << 8,
        },
 };
 
@@ -288,37 +291,50 @@ static void lpss_ssp_setup(struct driver_data *drv_data)
        }
 }
 
+static void lpss_ssp_select_cs(struct driver_data *drv_data,
+                              const struct lpss_config *config)
+{
+       u32 value, cs;
+
+       if (!config->cs_sel_mask)
+               return;
+
+       value = __lpss_ssp_read_priv(drv_data, config->reg_cs_ctrl);
+
+       cs = drv_data->cur_msg->spi->chip_select;
+       cs <<= config->cs_sel_shift;
+       if (cs != (value & config->cs_sel_mask)) {
+               /*
+                * When switching another chip select output active the
+                * output must be selected first and wait 2 ssp_clk cycles
+                * before changing state to active. Otherwise a short
+                * glitch will occur on the previous chip select since
+                * output select is latched but state control is not.
+                */
+               value &= ~config->cs_sel_mask;
+               value |= cs;
+               __lpss_ssp_write_priv(drv_data,
+                                     config->reg_cs_ctrl, value);
+               ndelay(1000000000 /
+                      (drv_data->master->max_speed_hz / 2));
+       }
+}
+
 static void lpss_ssp_cs_control(struct driver_data *drv_data, bool enable)
 {
        const struct lpss_config *config;
-       u32 value, cs;
+       u32 value;
 
        config = lpss_get_config(drv_data);
 
+       if (enable)
+               lpss_ssp_select_cs(drv_data, config);
+
        value = __lpss_ssp_read_priv(drv_data, config->reg_cs_ctrl);
-       if (enable) {
-               cs = drv_data->cur_msg->spi->chip_select;
-               cs <<= LPSS_CS_CONTROL_CS_SEL_SHIFT;
-               if (cs != (value & LPSS_CS_CONTROL_CS_SEL_MASK)) {
-                       /*
-                        * When switching another chip select output active
-                        * the output must be selected first and wait 2 ssp_clk
-                        * cycles before changing state to active. Otherwise
-                        * a short glitch will occur on the previous chip
-                        * select since output select is latched but state
-                        * control is not.
-                        */
-                       value &= ~LPSS_CS_CONTROL_CS_SEL_MASK;
-                       value |= cs;
-                       __lpss_ssp_write_priv(drv_data,
-                                             config->reg_cs_ctrl, value);
-                       ndelay(1000000000 /
-                              (drv_data->master->max_speed_hz / 2));
-               }
+       if (enable)
                value &= ~LPSS_CS_CONTROL_CS_HIGH;
-       } else {
+       else
                value |= LPSS_CS_CONTROL_CS_HIGH;
-       }
        __lpss_ssp_write_priv(drv_data, config->reg_cs_ctrl, value);
 }