qla2xxx: Use kmemdup instead of kmalloc + memcpy

This issue was reported by coccicheck using the semantic patch
at scripts/coccinelle/api/memdup.cocci

Signed-off-by: Benoit Taine <benoit.taine@lip6.fr>
Acked-by: Saurav Kashyap <saurav.kashyap@qlogic.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>

diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c
index 7f39e3605027aff1f4c78845aa912c3fb069a20e..1c33a77db5c235827a2c284f1aa14fc6407dcaef 100644 (file)
--- a/drivers/scsi/qla2xxx/qla_mbx.c
+++ b/drivers/scsi/qla2xxx/qla_mbx.c
@@ -1319,7 +1319,7 @@ qla2x00_get_node_name_list(scsi_qla_host_t *vha, void **out_data, int *out_len)
 
                left = 0;
 
-               list = kzalloc(dma_size, GFP_KERNEL);
+               list = kmemdup(pmap, dma_size, GFP_KERNEL);
                if (!list) {
                        ql_log(ql_log_warn, vha, 0x1140,
                            "%s(%ld): failed to allocate node names list "
@@ -1328,7 +1328,6 @@ qla2x00_get_node_name_list(scsi_qla_host_t *vha, void **out_data, int *out_len)
                        goto out_free;
                }
 
-               memcpy(list, pmap, dma_size);
 restart:
                dma_free_coherent(&ha->pdev->dev, dma_size, pmap, pmap_dma);
        }