V4L/DVB: TM6000: Fix code which cause memory corruption
authorBee Hock Goh <beehock@gmail.com>
Wed, 7 Apr 2010 23:57:19 +0000 (20:57 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Wed, 19 May 2010 15:57:33 +0000 (12:57 -0300)
The driver was doing malloc when buf is null causing memory corruption.

The analog part is still pretty much broken but at least fixing this
will stop it from crashing the machine when streamon.

Signed-off-by: Bee Hock Goh <beehock@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/staging/tm6000/tm6000-video.c

index 67f4d2908c355cdcb2fb425b106d6b5a056b87d6..be6fcb79ef07f385968c32d9e23a5eb5199c8a2b 100644 (file)
@@ -491,7 +491,7 @@ static inline int tm6000_isoc_copy(struct urb *urb)
        unsigned long copied;
 
        get_next_buf(dma_q, &buf);
-       if (!buf)
+       if (buf)
                outp = videobuf_to_vmalloc(&buf->vb);
 
        if (!outp)