boot, efi: Remove redundant memset()
authorRoy Franz <roy.franz@linaro.org>
Fri, 4 Oct 2013 16:02:46 +0000 (09:02 -0700)
committerMatt Fleming <matt.fleming@intel.com>
Fri, 4 Oct 2013 19:07:47 +0000 (20:07 +0100)
Remove a redundant memset() call from efi_relocate_kernel() that
was clearing memory that would be used by BSS in non-compressed
images loaded with this function.  This clear was redundant with
the clearing done in the image itself, and also implemented incorrectly
with a 0 length.

Signed-off-by: Roy Franz <roy.franz@linaro.org>
Acked-by: Mark Salter <msalter@redhat.com>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
drivers/firmware/efi/efi-stub-helper.c

index cc0581daa9edee1c9925c2e29af1fa837e9b5aa8..b6bffbfd3be7a14131c7735960a12db3f43b122d 100644 (file)
@@ -567,8 +567,6 @@ static efi_status_t efi_relocate_kernel(efi_system_table_t *sys_table_arg,
         * have been allocated by UEFI, so we can safely use memcpy.
         */
        memcpy((void *)new_addr, (void *)cur_image_addr, image_size);
-       /* Zero any extra space we may have allocated for BSS. */
-       memset((void *)(new_addr + image_size), alloc_size - image_size, 0);
 
        /* Return the new address of the relocated image. */
        *image_addr = new_addr;