arm64: use readq() instead of readl() to read 64bit entry_point
authorLuc Van Oostenryck <luc.vanoostenryck@gmail.com>
Mon, 26 Jun 2017 13:16:25 +0000 (15:16 +0200)
committerWill Deacon <will.deacon@arm.com>
Thu, 29 Jun 2017 10:33:01 +0000 (11:33 +0100)
Here the entrypoint, declared as a 64 bit integer, is read from
a pointer to 64bit integer but the read is done via readl_relaxed()
which is for 32bit quantities.

All the high bits will thus be lost which change the meaning
of the test against zero done later.

Fix this by using readq_relaxed() instead as it should be for
64bit quantities.

Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
arch/arm64/kernel/acpi_parking_protocol.c

index 1f5655cd9cc93280b92417370be49c808fe3bb1d..f35e80aad3789e0af1cb98568179552390c69860 100644 (file)
@@ -125,7 +125,7 @@ static void acpi_parking_protocol_cpu_postboot(void)
        struct parking_protocol_mailbox __iomem *mailbox = cpu_entry->mailbox;
        __le64 entry_point;
 
-       entry_point = readl_relaxed(&mailbox->entry_point);
+       entry_point = readq_relaxed(&mailbox->entry_point);
        /*
         * Check if firmware has cleared the entry_point as expected
         * by the protocol specification.