projects / GitHub / moto-9609 / android_kernel_motorola_exynos9610.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 37e7856)
[media] cx24120: do not allow an invalid delivery system types
authorColin Ian King <colin.king@canonical.com>
Sat, 3 Sep 2016 17:04:17 +0000 (14:04 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Mon, 24 Oct 2016 19:00:42 +0000 (17:00 -0200)
cx24120_set_frontend currently allows invalid delivery system types
other than SYS_DVBS2 and SYS_DVBS.  Fix this by returning -EINVAL
for invalid values.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Jemma Denson <jdenson@gmail.com>
drivers/media/dvb-frontends/cx24120.c patch | blob | blame | history

diff --git a/drivers/media/dvb-frontends/cx24120.c b/drivers/media/dvb-frontends/cx24120.c
index 066ee387bf250894b1067b023b2d1d760790ad02..3112a3206d4670d518be371611d07d82e21fc030 100644 (file)
--- a/drivers/media/dvb-frontends/cx24120.c
+++ b/drivers/media/dvb-frontends/cx24120.c
@@ -1154,8 +1154,7 @@ static int cx24120_set_frontend(struct dvb_frontend *fe)
                dev_dbg(&state->i2c->dev,
                        "delivery system(%d) not supported\n",
                        c->delivery_system);
-               ret = -EINVAL;
-               break;
+               return -EINVAL;
        }
 
        state->dnxt.delsys = c->delivery_system;