projects
/
GitHub
/
mt8127
/
android_kernel_alcatel_ttab.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
3873bc5
)
NFSv4: remove obviously bogus comparison from decode_getacl
author
J. Bruce Fields
<bfields@fieldses.org>
Tue, 30 May 2006 20:28:58 +0000
(16:28 -0400)
committer
Trond Myklebust
<Trond.Myklebust@netapp.com>
Fri, 9 Jun 2006 13:34:13 +0000
(09:34 -0400)
We just set *acl_len to zero, and attrlen is unsigned, so this comparison
is clearly bogus. I have no idea what I was thinking.
Fixes a bug that caused getacl to fail over krb5p.
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
fs/nfs/nfs4xdr.c
patch
|
blob
|
blame
|
history
diff --git
a/fs/nfs/nfs4xdr.c
b/fs/nfs/nfs4xdr.c
index 7c5d70efe720d34130362459c29d8e53a4a15392..7e9a840057f2ae3dd4fd13d96cc40c0206d55971 100644
(file)
--- a/
fs/nfs/nfs4xdr.c
+++ b/
fs/nfs/nfs4xdr.c
@@
-3350,8
+3350,7
@@
static int decode_getacl(struct xdr_stream *xdr, struct rpc_rqst *req,
attrlen, recvd);
return -EINVAL;
}
- if (attrlen <= *acl_len)
- xdr_read_pages(xdr, attrlen);
+ xdr_read_pages(xdr, attrlen);
*acl_len = attrlen;
} else
status = -EOPNOTSUPP;