netfilter: Remove IP_CT_NEW_REPLY definition.

Remove the definition of IP_CT_NEW_REPLY from the kernel as it does
not make sense.  This allows the definition of IP_CT_NUMBER to be
simplified as well.

Signed-off-by: Jarno Rajahalme <jarno@ovn.org>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

diff --git a/include/uapi/linux/netfilter/nf_conntrack_common.h b/include/uapi/linux/netfilter/nf_conntrack_common.h
index 319f47128db8c117563efa26d4cd54e1c3ac2cc2..6d074d14ee274309f9e35b967e1728f26506fd6e 100644 (file)
--- a/include/uapi/linux/netfilter/nf_conntrack_common.h
+++ b/include/uapi/linux/netfilter/nf_conntrack_common.h
@@ -20,9 +20,15 @@ enum ip_conntrack_info {
 
        IP_CT_ESTABLISHED_REPLY = IP_CT_ESTABLISHED + IP_CT_IS_REPLY,
        IP_CT_RELATED_REPLY = IP_CT_RELATED + IP_CT_IS_REPLY,
-       IP_CT_NEW_REPLY = IP_CT_NEW + IP_CT_IS_REPLY,   
-       /* Number of distinct IP_CT types (no NEW in reply dirn). */
-       IP_CT_NUMBER = IP_CT_IS_REPLY * 2 - 1
+       /* No NEW in reply direction. */
+
+       /* Number of distinct IP_CT types. */
+       IP_CT_NUMBER,
+
+       /* only for userspace compatibility */
+#ifndef __KERNEL__
+       IP_CT_NEW_REPLY = IP_CT_NUMBER,
+#endif
 };
 
 #define NF_CT_STATE_INVALID_BIT                        (1 << 0)

diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c
index ee6ff8ffc12d924655f111307233d7a8bb88e638..30452901574414458a93ffa1d345bf331d8e6f0c 100644 (file)
--- a/net/openvswitch/conntrack.c
+++ b/net/openvswitch/conntrack.c
@@ -75,7 +75,6 @@ static u8 ovs_ct_get_state(enum ip_conntrack_info ctinfo)
        switch (ctinfo) {
        case IP_CT_ESTABLISHED_REPLY:
        case IP_CT_RELATED_REPLY:
-       case IP_CT_NEW_REPLY:
                ct_state |= OVS_CS_F_REPLY_DIR;
                break;
        default:
@@ -92,7 +91,6 @@ static u8 ovs_ct_get_state(enum ip_conntrack_info ctinfo)
                ct_state |= OVS_CS_F_RELATED;
                break;
        case IP_CT_NEW:
-       case IP_CT_NEW_REPLY:
                ct_state |= OVS_CS_F_NEW;
                break;
        default: