[PATCH] drivers/mfd/sm501.c: fix an off-by-one
authorAdrian Bunk <bunk@stusta.de>
Mon, 2 Apr 2007 06:49:38 +0000 (23:49 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Mon, 2 Apr 2007 17:06:08 +0000 (10:06 -0700)
Fix an off-by-one spotted by the Coverity checker.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Cc: Ben Dooks <ben-linux@fluff.org>
Cc: Vincent Sanders <vince@arm.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/mfd/sm501.c

index c707c8ebc1a25be72e16938feeb76f172331d55a..b0b4458ae90b7adea36b371a72957b59c4a57578 100644 (file)
@@ -319,7 +319,7 @@ int sm501_unit_power(struct device *dev, unsigned int unit, unsigned int to)
 
        mode &= 3;              /* get current power mode */
 
-       if (unit > ARRAY_SIZE(sm->unit_power)) {
+       if (unit >= ARRAY_SIZE(sm->unit_power)) {
                dev_err(dev, "%s: bad unit %d\n", __FUNCTION__, unit);
                goto already;
        }