r8152: move the initialization to reset_resume function
authorhayeswang <hayeswang@realtek.com>
Fri, 9 Jun 2017 09:11:45 +0000 (17:11 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 9 Jun 2017 19:37:01 +0000 (15:37 -0400)
Move tp->rtl_ops.init() from rtl8152_resume() to rtl8152_reset_resume().
The initialization is only necessary for reset_resume().

Signed-off-by: Hayes Wang <hayeswang@realtek.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/r8152.c

index f78111c1ae406f7cfe89806b2e19b9856bbd22cd..f43b7a8ecfffc72b22500c3603cad34bfb366ebf 100644 (file)
@@ -3776,11 +3776,8 @@ static int rtl8152_resume(struct usb_interface *intf)
 
        mutex_lock(&tp->control);
 
-       if (!test_bit(SELECTIVE_SUSPEND, &tp->flags)) {
-               tp->rtl_ops.init(tp);
-               queue_delayed_work(system_long_wq, &tp->hw_phy_work, 0);
+       if (!test_bit(SELECTIVE_SUSPEND, &tp->flags))
                netif_device_attach(netdev);
-       }
 
        if (netif_running(netdev) && netdev->flags & IFF_UP) {
                if (test_bit(SELECTIVE_SUSPEND, &tp->flags)) {
@@ -3826,6 +3823,10 @@ static int rtl8152_reset_resume(struct usb_interface *intf)
        struct r8152 *tp = usb_get_intfdata(intf);
 
        clear_bit(SELECTIVE_SUSPEND, &tp->flags);
+       mutex_lock(&tp->control);
+       tp->rtl_ops.init(tp);
+       queue_delayed_work(system_long_wq, &tp->hw_phy_work, 0);
+       mutex_unlock(&tp->control);
        return rtl8152_resume(intf);
 }