media: mfc: fix build error(clang)
authorJeonghee Kim <jhhhh.kim@samsung.com>
Fri, 23 Mar 2018 09:10:06 +0000 (18:10 +0900)
committerSunyoung Kang <sy0816.kang@samsung.com>
Tue, 29 May 2018 06:59:18 +0000 (15:59 +0900)
Change-Id: Ib036206d2f0374d80065e8f8552f9749868839fd
Signed-off-by: Jeonghee Kim <jhhhh.kim@samsung.com>
drivers/media/platform/exynos/mfc/s5p_mfc_dec_ops.c
drivers/media/platform/exynos/mfc/s5p_mfc_enc_internal.h
drivers/media/platform/exynos/mfc/s5p_mfc_enc_ops.c

index 0029d4956cae24372676324af44b4d35a3647d7f..b794812b05dd2c9c30cec21efe817cdd2d85d978 100644 (file)
@@ -901,7 +901,7 @@ static int s5p_mfc_dec_get_buf_update_val(struct s5p_mfc_ctx *ctx,
        struct s5p_mfc_buf_ctrl *buf_ctrl;
 
        list_for_each_entry(buf_ctrl, head, list) {
-               if ((buf_ctrl->id == id)) {
+               if (buf_ctrl->id == id) {
                        buf_ctrl->val = value;
                        mfc_debug(5, "++id: 0x%08x val: %d\n",
                                        buf_ctrl->id, buf_ctrl->val);
index 5ca05276426a6323510877a4f3db3e303ea2a921..cecafe200bc3ad1aa6142791057db62136c684c9 100644 (file)
@@ -1674,8 +1674,8 @@ static struct v4l2_queryctrl controls[] = {
                .id = V4L2_CID_MPEG_MFC_GET_EXTRA_BUFFER_SIZE,
                .type = V4L2_CTRL_TYPE_INTEGER,
                .name = "Get extra buffer size",
-               .minimum = 0,
-               .maximum = (2 << 31) - 1,
+               .minimum = INT_MIN,
+               .maximum = INT_MAX,
                .step = 1,
                .default_value = 0,
        },
index 62a748abcb1e950ab6151063442694346780657c..ab548a40042412e67e7e8523b06cf2ed6ae8cad2 100644 (file)
@@ -691,7 +691,7 @@ static int s5p_mfc_enc_get_buf_update_val(struct s5p_mfc_ctx *ctx,
        struct s5p_mfc_buf_ctrl *buf_ctrl;
 
        list_for_each_entry(buf_ctrl, head, list) {
-               if ((buf_ctrl->id == id)) {
+               if (buf_ctrl->id == id) {
                        buf_ctrl->val = value;
                        mfc_debug(5, "++id: 0x%08x val: %d\n",
                                        buf_ctrl->id, buf_ctrl->val);
@@ -1132,7 +1132,7 @@ static void mfc_enc_set_buf_ctrls_exception(struct s5p_mfc_ctx *ctx,
                MFC_WRITEL(value, S5P_FIMV_E_H264_NAL_CONTROL);
        }
 
-       if ((buf_ctrl->id == V4L2_CID_MPEG_MFC51_VIDEO_I_PERIOD_CH)) {
+       if (buf_ctrl->id == V4L2_CID_MPEG_MFC51_VIDEO_I_PERIOD_CH) {
                value = MFC_READL(S5P_FIMV_E_GOP_CONFIG2);
                buf_ctrl->old_val |= (value << 16) & 0x3FFF0000;
                value &= ~(0x3FFF);