KVM: VMX: Fix interrupt exit condition during emulation
authorAvi Kivity <avi@redhat.com>
Sun, 10 Jun 2012 15:07:57 +0000 (18:07 +0300)
committerAvi Kivity <avi@redhat.com>
Mon, 9 Jul 2012 11:19:02 +0000 (14:19 +0300)
Checking EFLAGS.IF is incorrect as we might be in interrupt shadow.  If
that is the case, the main loop will notice that and not inject the interrupt,
causing an endless loop.

Fix by using vmx_interrupt_allowed() to check if we can inject an interrupt
instead.

Signed-off-by: Avi Kivity <avi@redhat.com>
arch/x86/kvm/vmx.c

index debac4984347010bca9eac0051fc1235b5022a1b..6cdb40457695ff2385817b010c0a8b2cfff4a1b5 100644 (file)
@@ -4983,8 +4983,7 @@ static int handle_invalid_guest_state(struct kvm_vcpu *vcpu)
        intr_window_requested = cpu_exec_ctrl & CPU_BASED_VIRTUAL_INTR_PENDING;
 
        while (!guest_state_valid(vcpu) && count-- != 0) {
-               if (intr_window_requested
-                   && (kvm_get_rflags(&vmx->vcpu) & X86_EFLAGS_IF))
+               if (intr_window_requested && vmx_interrupt_allowed(vcpu))
                        return handle_interrupt_window(&vmx->vcpu);
 
                err = emulate_instruction(vcpu, 0);