perf tools: Refactor the code to strip command name with {l,r}trim()
authorTaeung Song <treeze.taeung@gmail.com>
Fri, 7 Apr 2017 14:24:21 +0000 (23:24 +0900)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 11 Apr 2017 18:23:26 +0000 (15:23 -0300)
After reading command name from /proc/<pid>/status, use ltrim() and
rtrim() to strip command name, not using just while loop, isspace() and
etc.

Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
Acked-by: David Ahern <dsahern@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1491575061-704-6-git-send-email-treeze.taeung@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/event.c

index 76b9c6bc8369617a9a1dde0f7da0254102a897c0..8255a26ac255748a72e2bdebb385e57fa0e4fc9f 100644 (file)
@@ -106,7 +106,7 @@ static int perf_event__get_comm_ids(pid_t pid, char *comm, size_t len,
        int fd;
        size_t size = 0;
        ssize_t n;
-       char *nl, *name, *tgids, *ppids;
+       char *name, *tgids, *ppids;
 
        *tgid = -1;
        *ppid = -1;
@@ -134,14 +134,7 @@ static int perf_event__get_comm_ids(pid_t pid, char *comm, size_t len,
 
        if (name) {
                name += 5;  /* strlen("Name:") */
-
-               while (*name && isspace(*name))
-                       ++name;
-
-               nl = strchr(name, '\n');
-               if (nl)
-                       *nl = '\0';
-
+               name = rtrim(ltrim(name));
                size = strlen(name);
                if (size >= len)
                        size = len - 1;