ACPI / APEI: Fix incorrect return value of ghes_proc()
authorPunit Agrawal <punit.agrawal@arm.com>
Tue, 18 Oct 2016 16:07:19 +0000 (17:07 +0100)
committerWilly Tarreau <w@1wt.eu>
Fri, 10 Feb 2017 10:04:05 +0000 (11:04 +0100)
commit 806487a8fc8f385af75ed261e9ab658fc845e633 upstream.

Although ghes_proc() tests for errors while reading the error status,
it always return success (0). Fix this by propagating the return
value.

Fixes: d334a49113a4a33 (ACPI, APEI, Generic Hardware Error Source memory error support)
Signed-of-by: Punit Agrawal <punit.agrawa.@arm.com>
Tested-by: Tyler Baicar <tbaicar@codeaurora.org>
Reviewed-by: Borislav Petkov <bp@suse.de>
[ rjw: Subject ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/acpi/apei/ghes.c

index fcd7d91cec34af25ed8ccfc32188a24b677c641b..070b843c37ee0f6e3b8fd1eabb5ad091848c516a 100644 (file)
@@ -647,7 +647,7 @@ static int ghes_proc(struct ghes *ghes)
        ghes_do_proc(ghes, ghes->estatus);
 out:
        ghes_clear_estatus(ghes);
-       return 0;
+       return rc;
 }
 
 static void ghes_add_timer(struct ghes *ghes)