MIPS: Xway: Fix clk leak
authorLibo Chen <clbchenlibo.chen@huawei.com>
Fri, 17 May 2013 05:21:31 +0000 (05:21 +0000)
committerRalf Baechle <ralf@linux-mips.org>
Fri, 17 May 2013 18:35:53 +0000 (20:35 +0200)
When gptu_r32 fails, we should put clk before returning.

Signed-off-by: Libo Chen <libo.chen@huawei.com>
Acked-by: John Crispin <blogic@openwrt.org>
Cc: grant.likely@linaro.org
Cc: rob.herring@calxeda.com,
Cc: linux-mips@linux-mips.org
Cc: LKML linux-kernel@vger.kernel.org
Cc: Andrew Morton akpm@linux-foundation.org
Cc: Li Zefan lizefan@huawei.com
Patchwork: https://patchwork.linux-mips.org/patch/5247/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
arch/mips/lantiq/xway/gptu.c

index 9861c8669fab4047da01ad6af587ef948817d169..4fa577c1ddfdb47238a33be03aa6997e94915eac 100644 (file)
@@ -169,6 +169,8 @@ static int gptu_probe(struct platform_device *pdev)
        if (((gptu_r32(GPTU_ID) >> 8) & 0xff) != GPTU_MAGIC) {
                dev_err(&pdev->dev, "Failed to find magic\n");
                gptu_hwexit();
+               clk_disable(clk);
+               clk_put(clk);
                return -ENAVAIL;
        }