NFC: st-nci: remove duplicated skb dump
authorChristophe Ricard <christophe.ricard@gmail.com>
Sun, 25 Oct 2015 21:54:49 +0000 (22:54 +0100)
committerSamuel Ortiz <sameo@linux.intel.com>
Tue, 27 Oct 2015 02:55:14 +0000 (03:55 +0100)
Remove SPI_DUMP_SKB and I2C_DUMP_SKB as skb is already dumped
in ndlc layer.

Signed-off-by: Christophe Ricard <christophe-h.ricard@st.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
drivers/nfc/st-nci/i2c.c
drivers/nfc/st-nci/spi.c

index 25e50426e4d7f373d3b2c775b22ba324f6f6e19a..15e3ce2d274c7691cf8c31595cd2482a86b636be 100644 (file)
@@ -58,13 +58,6 @@ struct st_nci_i2c_phy {
        struct st_nci_se_status se_status;
 };
 
-#define I2C_DUMP_SKB(info, skb)                                        \
-do {                                                           \
-       pr_debug("%s:\n", info);                                \
-       print_hex_dump(KERN_DEBUG, "i2c: ", DUMP_PREFIX_OFFSET, \
-                      16, 1, (skb)->data, (skb)->len, 0);      \
-} while (0)
-
 static int st_nci_i2c_enable(void *phy_id)
 {
        struct st_nci_i2c_phy *phy = phy_id;
@@ -101,8 +94,6 @@ static int st_nci_i2c_write(void *phy_id, struct sk_buff *skb)
        struct st_nci_i2c_phy *phy = phy_id;
        struct i2c_client *client = phy->i2c_dev;
 
-       I2C_DUMP_SKB("st_nci_i2c_write", skb);
-
        if (phy->ndlc->hard_fault != 0)
                return phy->ndlc->hard_fault;
 
@@ -173,8 +164,6 @@ static int st_nci_i2c_read(struct st_nci_i2c_phy *phy,
        skb_put(*skb, len);
        memcpy((*skb)->data + ST_NCI_I2C_MIN_SIZE, buf, len);
 
-       I2C_DUMP_SKB("i2c frame read", *skb);
-
        return 0;
 }
 
index bf6643c72f53ba93d5140afd3af67d1924d43d22..cf7ad8121e1139b9c14376fbf2afaf113ab00cf3 100644 (file)
@@ -59,13 +59,6 @@ struct st_nci_spi_phy {
        struct st_nci_se_status se_status;
 };
 
-#define SPI_DUMP_SKB(info, skb)                                        \
-do {                                                           \
-       pr_debug("%s:\n", info);                                \
-       print_hex_dump(KERN_DEBUG, "spi: ", DUMP_PREFIX_OFFSET, \
-                      16, 1, (skb)->data, (skb)->len, 0);      \
-} while (0)
-
 static int st_nci_spi_enable(void *phy_id)
 {
        struct st_nci_spi_phy *phy = phy_id;
@@ -110,8 +103,6 @@ static int st_nci_spi_write(void *phy_id, struct sk_buff *skb)
                .len = skb->len,
        };
 
-       SPI_DUMP_SKB("st_nci_spi_write", skb);
-
        if (phy->ndlc->hard_fault != 0)
                return phy->ndlc->hard_fault;
 
@@ -188,8 +179,6 @@ static int st_nci_spi_read(struct st_nci_spi_phy *phy,
        skb_put(*skb, len);
        memcpy((*skb)->data + ST_NCI_SPI_MIN_SIZE, buf, len);
 
-       SPI_DUMP_SKB("spi frame read", *skb);
-
        return 0;
 }