[media] drivers/media/pci/ngene/ngene-core.c: fix error return code
authorPeter Senna Tschudin <peter.senna@gmail.com>
Thu, 6 Sep 2012 14:23:54 +0000 (11:23 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 22 Nov 2012 16:20:25 +0000 (14:20 -0200)
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/pci/ngene/ngene-core.c

index 2c2df88b4a9cafa5f11123a67f45a3441903357d..8eeec4f50ccb4103d2db272b3c1bc6d7b2608f18 100644 (file)
@@ -1691,7 +1691,8 @@ int __devinit ngene_probe(struct pci_dev *pci_dev,
        dev->i2c_current_bus = -1;
 
        /* Register DVB adapters and devices for both channels */
-       if (init_channels(dev) < 0)
+       stat = init_channels(dev);
+       if (stat < 0)
                goto fail2;
 
        return 0;