[media] omap3isp: ccdc: Fix crash in HS/VS interrupt handler
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Fri, 11 Nov 2011 14:22:20 +0000 (11:22 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Tue, 20 Dec 2011 11:30:10 +0000 (09:30 -0200)
The HS/VS interrupt handler needs to access the pipeline object. It
erronously tries to get it from the CCDC output video node, which isn't
necessarily included in the pipeline. This leads to a NULL pointer
dereference.

Fix the bug by getting the pipeline object from the CCDC subdev entity.

Reported-by: Gary Thomas <gary@mlbassoc.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/omap3isp/ispccdc.c

index b0b0fa5a3572fb834a87c45dba668b798524dfad..9012b57b3cf0d8299e23829746e6b85d30f09b85 100644 (file)
@@ -1406,8 +1406,7 @@ static int __ccdc_handle_stopping(struct isp_ccdc_device *ccdc, u32 event)
 
 static void ccdc_hs_vs_isr(struct isp_ccdc_device *ccdc)
 {
-       struct isp_pipeline *pipe =
-               to_isp_pipeline(&ccdc->video_out.video.entity);
+       struct isp_pipeline *pipe = to_isp_pipeline(&ccdc->subdev.entity);
        struct video_device *vdev = &ccdc->subdev.devnode;
        struct v4l2_event event;