NFC: HCI ops should not be exposed globally
authorH Hartley Sweeten <hartleys@visionengravers.com>
Mon, 7 May 2012 10:31:27 +0000 (12:31 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Tue, 15 May 2012 21:30:30 +0000 (17:30 -0400)
The variable 'hci_nfc_ops' is only referenced in this file and
should be marked static to prevent it from being exposed globally.

Quites the sparse warning:

warning: symbol 'hci_nfc_ops' was not declared. Should it be static?

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Lauro Ramos Venancio <lauro.venancio@openbossa.org>
Cc: Aloisio Almeida Jr <aloisio.almeida@openbossa.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
net/nfc/hci/core.c

index f7e4f5ae4559afb007e9e7311f698de19a1abae5..0fdb96f152b10bcbb74fc13ee171699e3a5a4e9f 100644 (file)
@@ -585,7 +585,7 @@ static int hci_check_presence(struct nfc_dev *nfc_dev,
        return 0;
 }
 
-struct nfc_ops hci_nfc_ops = {
+static struct nfc_ops hci_nfc_ops = {
        .dev_up = hci_dev_up,
        .dev_down = hci_dev_down,
        .start_poll = hci_start_poll,