regulator: Fix the error handling if create_regulator fails
authorAxel Lin <axel.lin@gmail.com>
Thu, 29 Dec 2011 09:02:08 +0000 (17:02 +0800)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Thu, 29 Dec 2011 10:40:19 +0000 (10:40 +0000)
In the case of create_regulator() fails, goto the error path immediately.
It does not make sense to update rdev->open_count if create_regulator fails.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
drivers/regulator/core.c

index 6f7d411b048b4e677a5885fdeb4311b345eb17c0..6cb9d399affdd587d97323b6c0ca1889abfb3ed8 100644 (file)
@@ -1282,6 +1282,7 @@ found:
        if (regulator == NULL) {
                regulator = ERR_PTR(-ENOMEM);
                module_put(rdev->owner);
+               goto out;
        }
 
        rdev->open_count++;