ARM: amba: Make driver_override output consistent with other buses
authorGeert Uytterhoeven <geert+renesas@glider.be>
Tue, 10 Apr 2018 13:21:43 +0000 (15:21 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 1 May 2018 19:58:21 +0000 (12:58 -0700)
commit 5f53624662eaac89598641cee6cd54fc192572d9 upstream.

For AMBA devices with unconfigured driver override, the
"driver_override" sysfs virtual file is empty, while it contains
"(null)" for platform and PCI devices.

Make AMBA consistent with other buses by dropping the test for a NULL
pointer.

Note that contrary to popular belief, sprintf() handles NULL pointers
fine; they are printed as "(null)".

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: stable <stable@vger.kernel.org>
Reviewed-by: Todd Kjos <tkjos@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/amba/bus.c

index e0f74ddc22b73caf6b652092dd6a623739e58b5e..f349dae9421261bbb024e02ffe39790a95236377 100644 (file)
@@ -70,9 +70,6 @@ static ssize_t driver_override_show(struct device *_dev,
 {
        struct amba_device *dev = to_amba_device(_dev);
 
-       if (!dev->driver_override)
-               return 0;
-
        return sprintf(buf, "%s\n", dev->driver_override);
 }