projects
/
GitHub
/
mt8127
/
android_kernel_alcatel_ttab.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
c27e8c5
)
[ALSA] sound/isa/sb/sb_mixer.c double kfree
author
Dave Jones
<davej@redhat.com>
Mon, 6 Mar 2006 12:28:34 +0000
(13:28 +0100)
committer
Jaroslav Kysela
<perex@suse.cz>
Wed, 22 Mar 2006 09:35:57 +0000
(10:35 +0100)
Modules: SB drivers
snd_ctl_add() already does the free on error.
Coverity bug #957
Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/isa/sb/sb_mixer.c
patch
|
blob
|
blame
|
history
diff --git
a/sound/isa/sb/sb_mixer.c
b/sound/isa/sb/sb_mixer.c
index 1a6ee344dddb89d0985a7af00346a5a435b566bc..490b1ca5cf5882c3cff630dca4f637697e32117c 100644
(file)
--- a/
sound/isa/sb/sb_mixer.c
+++ b/
sound/isa/sb/sb_mixer.c
@@
-453,10
+453,8
@@
int snd_sbmixer_add_ctl(struct snd_sb *chip, const char *name, int index, int ty
strlcpy(ctl->id.name, name, sizeof(ctl->id.name));
ctl->id.index = index;
ctl->private_value = value;
- if ((err = snd_ctl_add(chip->card, ctl)) < 0) {
- snd_ctl_free_one(ctl);
+ if ((err = snd_ctl_add(chip->card, ctl)) < 0)
return err;
- }
return 0;
}