Btrfs: just free dummy extent buffers
authorJosef Bacik <jbacik@fb.com>
Mon, 16 Mar 2015 21:38:02 +0000 (17:38 -0400)
committerJosef Bacik <jbacik@fb.com>
Tue, 17 Mar 2015 20:30:18 +0000 (16:30 -0400)
If we fail during our sanity tests we could get NULL deref's because we unload
the module before the dummy extent buffers are free'd via RCU.  So check for
this case and just free the things directly.  Thanks,

Signed-off-by: Josef Bacik <jbacik@fb.com>
fs/btrfs/extent_io.c

index 29850d4a3827cf537c8aec5064609941ecfcaa8e..d13ceadcbf18b11329b6406506fc30cece1d7736 100644 (file)
@@ -4968,6 +4968,12 @@ static int release_extent_buffer(struct extent_buffer *eb)
 
                /* Should be safe to release our pages at this point */
                btrfs_release_extent_buffer_page(eb);
+#ifdef CONFIG_BTRFS_FS_RUN_SANITY_TESTS
+               if (unlikely(test_bit(EXTENT_BUFFER_DUMMY, &eb->bflags))) {
+                       __free_extent_buffer(eb);
+                       return 1;
+               }
+#endif
                call_rcu(&eb->rcu_head, btrfs_release_extent_buffer_rcu);
                return 1;
        }