projects / GitHub / LineageOS / android_kernel_motorola_exynos9610.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 0cf8af5)
[media] DVB: dvb_frontend: off by one in dtv_property_dump()
authorDan Carpenter <error27@gmail.com>
Thu, 26 May 2011 08:44:52 +0000 (05:44 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Wed, 27 Jul 2011 20:55:55 +0000 (17:55 -0300)
If the tvp->cmd == DTV_MAX_COMMAND then we read past the end of the
array.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/dvb/dvb-core/dvb_frontend.c patch | blob | blame | history

diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.c b/drivers/media/dvb/dvb-core/dvb_frontend.c
index efe9c30605e890688b6a7557156436fe0c4611a9..21c9072ed99fe40ca047d41e044ecfd06874648e 100644 (file)
--- a/drivers/media/dvb/dvb-core/dvb_frontend.c
+++ b/drivers/media/dvb/dvb-core/dvb_frontend.c
@@ -982,7 +982,7 @@ static void dtv_property_dump(struct dtv_property *tvp)
 {
        int i;
 
-       if (tvp->cmd <= 0 || tvp->cmd > DTV_MAX_COMMAND) {
+       if (tvp->cmd <= 0 || tvp->cmd >= DTV_MAX_COMMAND) {
                printk(KERN_WARNING "%s: tvp.cmd = 0x%08x undefined\n",
                        __func__, tvp->cmd);
                return;