md/bitmap: move storage allocation from bitmap_load to bitmap_create.
authorNeilBrown <neilb@suse.de>
Tue, 22 May 2012 03:55:12 +0000 (13:55 +1000)
committerNeilBrown <neilb@suse.de>
Tue, 22 May 2012 03:55:12 +0000 (13:55 +1000)
We should allocate memory for the storage-bitmap at create-time, not
load time.

Signed-off-by: NeilBrown <neilb@suse.de>
drivers/md/bitmap.c

index 4ac60ed66c49ae027ba82ad337ed50c9f1bb32c1..1a93ed1fb8df719865e1ae060398f9d3a7085bf4 100644 (file)
@@ -1032,11 +1032,6 @@ static int bitmap_init_from_disk(struct bitmap *bitmap, sector_t start)
                goto err;
        }
 
-       ret = bitmap_storage_alloc(&bitmap->storage, bitmap->chunks,
-                                  !bitmap->mddev->bitmap_info.external);
-       if (ret)
-               goto err;
-
        oldindex = ~0L;
        offset = 0;
        if (!bitmap->mddev->bitmap_info.external)
@@ -1782,6 +1777,12 @@ int bitmap_create(struct mddev *mddev)
        if (!bitmap->bp)
                goto error;
 
+       if (file || mddev->bitmap_info.offset) {
+               err = bitmap_storage_alloc(&bitmap->storage, bitmap->chunks,
+                                          !mddev->bitmap_info.external);
+               if (err)
+                       goto error;
+       }
        printk(KERN_INFO "created bitmap (%lu pages) for device %s\n",
                pages, bmname(bitmap));